Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49840 )
Change subject: cpu/x86/mp_init.c: Print out the microcode revision of APs ......................................................................
cpu/x86/mp_init.c: Print out the microcode revision of APs
It is useful to know if MCU have been applied successfully.
On the start of MP init lines similar to: "AP: slot 1 apic_id 1, MCU rev: 0x0700001d" will be printed. The example is taken from the log of an ocp/deltalake.
Change-Id: Ia0a6428b41d07f87943f3aa7736b8cb457fdd15a Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/49840 Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/cpu/x86/mp_init.c 1 file changed, 6 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index c691c48..cca6093 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -196,8 +196,12 @@ /* Fix up APIC id with reality. */ info->cpu->path.apic.apic_id = lapicid();
- printk(BIOS_INFO, "AP: slot %d apic_id %x.\n", cpu, - info->cpu->path.apic.apic_id); + if (cpu_is_intel()) + printk(BIOS_INFO, "AP: slot %d apic_id %x, MCU rev: 0x%08x\n", cpu, + info->cpu->path.apic.apic_id, get_current_microcode_rev()); + else + printk(BIOS_INFO, "AP: slot %d apic_id %x\n", cpu, + info->cpu->path.apic.apic_id);
/* Walk the flight plan */ ap_do_flight_plan();