Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33616 )
Change subject: kodama: add a new configuration for Kodama. ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/c/coreboot/+/33616/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33616/4//COMMIT_MSG@7 PS4, Line 7: kodama: add a new configuration for Kodama. Please remove the dot/period at the end of the commit message.
https://review.coreboot.org/c/coreboot/+/33616/4//COMMIT_MSG@7 PS4, Line 7: kodama Please look through `git log --oneline` what a proper prefix would be.
https://review.coreboot.org/c/coreboot/+/33616/4//COMMIT_MSG@10 PS4, Line 10: add panel driver for Kodama. Please remove the space at the beginning of the line.
https://review.coreboot.org/c/coreboot/+/33616/4//COMMIT_MSG@9 PS4, Line 9: This config file could be configured Kodama project and : add panel driver for Kodama. Please use the full text width.
https://review.coreboot.org/c/coreboot/+/33616/4//COMMIT_MSG@17 PS4, Line 17: the /build/chroot/kukui/firmware/. *the* can be put on the line above.