Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40910 )
Change subject: soc/amd/picasso/Makefile: Allow absolute path for picasso firmware
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40910/1/src/soc/amd/picasso/Makefil...
File src/soc/amd/picasso/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40910/1/src/soc/amd/picasso/Makefil...
PS1, Line 97: FIRMWARE_LOCATE=$(realpath $(dir $(call strip_quotes, $(CONFIG_AMD_PUBKEY_FILE))))
In your script, you will have to ensure that you copy 3rdparty/blobs as installed by the private cor […]
So I no longer need this patch for my script. I would still like to merge this just as a clean up. If we want to do other refactorings we can do that in a follow up.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40910
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib46b1799fad5588a18411f8c32541192d699cdd4
Gerrit-Change-Number: 40910
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 02 Jun 2020 15:45:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment