Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42797 )
Change subject: sb/intel/ibexpeak/smihandler: Comment out unused variable assignment
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42797/1/src/southbridge/intel/ibexp...
File src/southbridge/intel/ibexpeak/smihandler.c:
https://review.coreboot.org/c/coreboot/+/42797/1/src/southbridge/intel/ibexp...
PS1, Line 135: // data &= mask;
: // if (smi1)
: // southbridge_smi_command(data);
: // return;
I do not know. I can do that in a follow-up. […]
I did CB:43269
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42797
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62060aacfec72a7066ee8c6464231c2ad5203a2a
Gerrit-Change-Number: 42797
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Wed, 08 Jul 2020 10:59:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment