[coreboot-gerrit] [S] Change in coreboot[main]: intelblocks/acpi/notrhbridge.asl: Reserve SBREG BAR

[Michał Żygowski (Code Review)]

Attention is currently required from: Arthur Heymans, Christian Walter, CoolStar, Eran Mitrani, Jakub Czapiga, Jeremy Soller, Johnny Lin, Kapil Porwal, Krystian Hebel, Lean Sheng Tan, Martin L Roth, Matt DeVillier, Nick Vaccaro, Paul Menzel, Subrata Banik, Tarun, Tim Chu.

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77445?usp=email )

Change subject: intelblocks/acpi/notrhbridge.asl: Reserve SBREG BAR
......................................................................

Patch Set 16:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/77445/comment/18760b9a_63e9c6eb :
PS15, Line 7: intelblocks/acpi/notrhbridge.asl
> Why not soc/intel: acpi: Reserve SBREG BAR

Currently I am touching only the northbridge.asl file so I don't see a need to generalize the commit title.

https://review.coreboot.org/c/coreboot/+/77445/comment/6c27f76a_b491686e :
PS15, Line 13:
> Did you notice problems in the field? Please add a TEST= line, how you tested this.

There were no problems in particular. However, who knows what could happen when the region was not reserved.

Patchset:

PS15:
> Most of this commit is a style change that isn't even noted in the commit message. […]

Reverted the changes in iomap.h files.

File src/soc/intel/alderlake/include/soc/iomap.h:

https://review.coreboot.org/c/coreboot/+/77445/comment/b6300b7c_aacfc7be :
PS15, Line 127: (256 * MiB)
> The header containing MiB definition isn't probably included anywhere in the ASL.

Fixed

File src/soc/intel/apollolake/include/soc/iomap.h:

https://review.coreboot.org/c/coreboot/+/77445/comment/a65dd9c9_eed513c0 :
PS15, Line 9: (16 * MiB)
> again, why change this? This is more readable, and seems to have nothing to do with the SBREG BAR ch […]

Fixed, by including the appropriate helpers.h file in ASL.