[coreboot-gerrit] Change in coreboot[master]: src/soc/intel/{common,cnl,skl,icl}: Move global reset req function to...

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35228 )

Change subject: src/soc/intel/{common,cnl,skl,icl}: Move global reset req function to common
......................................................................

Patch Set 25:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35228/25/src/soc/intel/common/block... 
File src/soc/intel/common/block/cse/cse.c:

https://review.coreboot.org/c/coreboot/+/35228/25/src/soc/intel/common/block... 
PS25, Line 577: The reset type can be GLOBAL_RESET/
              :  * HOST_RESET_ONLY/CSE_RESET_ONLY.
> Yes,to be more precise, it is supported from ME 6.0 onwards and also on TXE 3.0 and 4.0.

How do those versions translate to the different platforms here?

https://review.coreboot.org/c/coreboot/+/35228/25/src/soc/intel/common/block... 
PS25, Line 609: 	if (rst_type == CSE_RESET_ONLY)
> Aah, ok. […]

How does the host know that CSE_RESET request was accepted? How does it know when the reset was complete? I believe it is important for host to know that because future operations would depend on this?