jonzhang@fb.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34636 )
Change subject: mb/ocp/monolake: use RW_VPD to configure FSP UPD
......................................................................
Patch Set 8:
(1 comment)
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/34636/5/src/mainboard/ocp/monolake/...
File src/mainboard/ocp/monolake/vpd_fsp.h:
https://review.coreboot.org/c/coreboot/+/34636/5/src/mainboard/ocp/monolake/...
PS5, Line 4: Copyright (C) 2019 The coreboot Authors.
: *
: * This program is free software; you can redistribute it and/or modify
: * it under the terms of the GNU General Public License as published by
: * the Free Software Foundation; version 2 of the License.
: *
: * This program is distributed in the hope that it will be useful,
: * but WITHOUT ANY WARRANTY; without even the implied warranty of
: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
: * GNU General Public License for more details.
Copyright should be: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34636
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I799d27734fe4b67cd1f40cae710151a01562b1b2
Gerrit-Change-Number: 34636
Gerrit-PatchSet: 8
Gerrit-Owner: jonzhang@fb.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martin.roth@tinkermill.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jonzhang@fb.com
Gerrit-Reviewer: Łukasz Siudut
Gerrit-Comment-Date: Wed, 31 Jul 2019 16:04:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Gerrit-MessageType: comment