Vinod Polimera has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39615 )
Change subject: sc7180: Add display hardware pipe line initialization ......................................................................
Patch Set 34:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39615/25/src/mainboard/google/trogd... File src/mainboard/google/trogdor/Kconfig:
https://review.coreboot.org/c/coreboot/+/39615/25/src/mainboard/google/trogd... PS25, Line 21: select DRIVERS_TI_SN65DSI86BRIDGE
Well, I mean it's still not fixed. […]
I have moved to correct order in the bridge patch, as the other patch required this change to fix build failure. So This is Done
https://review.coreboot.org/c/coreboot/+/39615/32/src/mainboard/google/trogd... File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39615/32/src/mainboard/google/trogd... PS32, Line 8: #include "board.h"
Please order the headers with "double quotes" below all the headers with <angled brackets> with a bl […]
done
https://review.coreboot.org/c/coreboot/+/39615/32/src/mainboard/google/trogd... PS32, Line 93: 200
Update: Pompom guys confirmed that 250ms is enough to fix their issues, so please just update this n […]
done
https://review.coreboot.org/c/coreboot/+/39615/25/src/soc/qualcomm/sc7180/di... File src/soc/qualcomm/sc7180/display/mdss.c:
https://review.coreboot.org/c/coreboot/+/39615/25/src/soc/qualcomm/sc7180/di... PS25, Line 156: 0x00000003
*ping* (still unresolved)
Updated Comment. These are LUT values from HW settings.