Attention is currently required from: Christian Walter, Angel Pons, Michael Niewöhner, Patrick Rudolph.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58065 )
Change subject: mb/prodrive/hermes: Fix PCIe ClkSrc configuration
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58065/comment/467b17e2_a4851aa5
PS2, Line 10: Apparently, FSP does not turn off unused PCIe clock sources when using
I cannot find that code in FSP, where does it check for SPS?
https://review.coreboot.org/c/coreboot/+/58065/comment/4fa32c8b_cd532426
PS2, Line 12: firmware.
It's more likely that the 1:1 mapping of "SRC$ CLKREQ#" to pin in the new IFD causes problems.
The original IFD had the "SRC$ CLKREQ#" to pin mapping as described in the devicetree.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58065
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id25a34816f512510640db95251a7a792c1eebe62
Gerrit-Change-Number: 58065
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 04 Oct 2021 09:07:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment