[coreboot-gerrit] [S] Change in coreboot[main]: lib: Refactor bmp_load_logo() implementation

[Subrata Banik (Code Review)]

Attention is currently required from: Andrey Petrov, Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Matt DeVillier, Ronak Kanabar, Sean Rhodes.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81618?usp=email )

Change subject: lib: Refactor bmp_load_logo() implementation
......................................................................

Patch Set 4:

(2 comments)

File src/drivers/intel/fsp1_1/ramstage.c:

https://review.coreboot.org/c/coreboot/+/81618/comment/ab83d0db_f8df3050 :
PS3, Line 81: uint32_t
> Yes, that. The cast to `uint32_t` is optional but the other one is not.

Acknowledged

File src/drivers/intel/fsp2_0/fsp_gop_blt.c:

https://review.coreboot.org/c/coreboot/+/81618/comment/8841bed5_37f9905e :
PS3, Line 241: logo_size_t
> I think it would be cleaner to change the type for `logo_ptr_size` here already tbh.

Acknowledged