Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/28937 )
Change subject: soc/intel/cannonlake: Add back PM TIMER EMULATION
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/28937/2/src/soc/intel/cannonlake/cpu.c
File src/soc/intel/cannonlake/cpu.c:
https://review.coreboot.org/#/c/28937/2/src/soc/intel/cannonlake/cpu.c@187
PS2, Line 187: MSR_EMULATE_PM_TMR
This is defined here soc/intel/common/block/include/intelblocks/msr.h,
but also we have it here : src/soc/intel/skylake/include/soc/msr.h as "MSR_EMULATE_PM_TIMER"
and we cab see also "EMULATE_DELAY_VALUE" ...
Maybe we can fix the name and move this msr and linked registers bit to "soc/intel/common/block/include/intelblocks/msr.h" ?
--
To view, visit
https://review.coreboot.org/28937
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie069e815e6244c3f85fabf51e186311621d316fd
Gerrit-Change-Number: 28937
Gerrit-PatchSet: 2
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes HAOUAS
ehaouas@noos.fr
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Fri, 05 Oct 2018 19:26:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No