Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38221 )
Change subject: soc/amd/picasso: Drop forked copy of SMBus source ......................................................................
Patch Set 4:
Picking order or precedence in coreboot framework as I see it: - Individual boards don't get to block or dictate platform APIs. - Platform APIs don't get to block or dictate subsystem (PCI, ACPI, SMBus, etc) APIs. - Subsystems and arch/ need to evolve closely together for meaningful placement of header files to avoid guards around includes common code.
Blocking above can be understood as parallel works or duplicate implementations that cause naming collisions in a namespace, of which the subsystem should have complete ownership.
Unnecessary and untested features of a new platform like amd/picasso should not be committed to master until there is at least a build-tested change with the actual dependency. Did I miss the dependency? AFAIR Marshall already commented that he should have moved amd/stoneyridge SMBus code instead of forking another copy.
Now, if you ask me, in the cases when a commercial player blocks the work of a community task targeting a somewhat major cleanup on a subsystem, responsibility of said subsystem maintenance should be transferred to that vendor with an enforced deadline. I feel pretty disgusted of Martin and Marshall giving empty promises on behalf of AMD of supplying me with the CRB in question here since Sep 2019 and them having requestsed me personally on helping to clean topics around CAR since early Aug 2019. M & M: You are collecting enemies ánd losing competent reviewers fast.
Topic wipe-PRE_RAM reviews completed without much or any interaction from AMD in the period Aug 18-Nov 22. Largely thanks to Arthur, CAR_GLOBAL and ROMCC removals completed in December. As of Jan 25th 2020 even the NDA part for PCO documentation has not been completed or even communicated from AMD side.
This gets ugly, off-topic and non-techical fast -- further discussions by email with the leadership in Cc.