Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45479 )
Change subject: soc/amd/picasso/acpi: add UART DMA controller devices ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45479/1/src/soc/amd/picasso/acpi/sb... File src/soc/amd/picasso/acpi/sb_fch.asl:
https://review.coreboot.org/c/coreboot/+/45479/1/src/soc/amd/picasso/acpi/sb... PS1, Line 182: Device (DMA3) { How does the driver associate these devices w/ the proper uart? Is that going to be open coded somehow to provide the binding? There doesn't appear to be any topology information encoded in the hierarchy because all these devices just float together.
https://review.coreboot.org/c/coreboot/+/45479/1/src/soc/amd/picasso/acpi/sb... PS1, Line 221: Exclusive You changed FUR1, FUR2, and FUR3 to Shared.