Hello Matt DeVillier,
I'd like you to do a code review. Please visit
https://review.coreboot.org/19895
to review the following change.
Change subject: purism/librem13v2: fix HDA verb values, use azalia macros ......................................................................
purism/librem13v2: fix HDA verb values, use azalia macros
use values from AMI firmware, other coreboot boards with Realtek ALC269 as reference. Fixes headphone jack detection.
Change-Id: I500e7bcad0a5eba5676e9e1afbef3914ee450e9e Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/purism/librem13v2/hda_verb.h 1 file changed, 17 insertions(+), 50 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/19895/1
diff --git a/src/mainboard/purism/librem13v2/hda_verb.h b/src/mainboard/purism/librem13v2/hda_verb.h index d76cc17..323ee9a 100644 --- a/src/mainboard/purism/librem13v2/hda_verb.h +++ b/src/mainboard/purism/librem13v2/hda_verb.h @@ -25,10 +25,10 @@ 0x19910269, /* Subsystem ID */ 0x0000000c, /* Number of jacks (NID entries) */
- 0x0017ff00, /* Function Reset */ - 0x0017ff00, /* Double Function Reset */ - 0x0017ff00, - 0x0017ff00, + 0x0017ff00, // Function Reset + 0x0017ff00, // Double Function Reset + 0x000F0000, // Pad - get vendor id + 0x000F0002, // Pad - get revision id
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ @@ -36,72 +36,39 @@ /* Bits 7:0 - Payload */
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x19910269 */ - 0x00172069, - 0x00172102, - 0x00172291, - 0x00172319, + AZALIA_SUBVENDOR(0x0, 0x19910269),
/* Pin Widget Verb Table */
/* Pin Complex (NID 0x12) */ - 0x01271c00, - 0x01271d00, - 0x01271e00, - 0x01271f40, + AZALIA_PIN_CFG(0x0, 0x12, 0x40000000),
/* Pin Complex (NID 0x14) */ - 0x01471c10, - 0x01471d01, - 0x01471e17, - 0x01471f90, + AZALIA_PIN_CFG(0x0, 0x14, 0x90170110), + + /* Pin Complex (NID 0x15) */ + AZALIA_PIN_CFG(0x0, 0x15, 0x04214020),
/* Pin Complex (NID 0x17) */ - 0x01771cf0, - 0x01771d11, - 0x01771e11, - 0x01771f41, + AZALIA_PIN_CFG(0x0, 0x17, 0x411111f0),
/* Pin Complex (NID 0x18) */ - 0x01871c20, - 0x01871d10, - 0x01871ea1, - 0x01871f04, + AZALIA_PIN_CFG(0x0, 0x18, 0x04a19040),
/* Pin Complex (NID 0x19) */ - 0x01971c30, - 0x01971d01, - 0x01971ea7, - 0x01971f90, + AZALIA_PIN_CFG(0x0, 0x19, 0x90a70130),
/* Pin Complex (NID 0x1A) */ - 0x01a71cf0, - 0x01a71d11, - 0x01a71e11, - 0x01a71f41, + AZALIA_PIN_CFG(0x0, 0x1A, 0x411111f0),
/* Pin Complex (NID 0x1B) */ - 0x01b71cf0, - 0x01b71d11, - 0x01b71e11, - 0x01b71f41, + AZALIA_PIN_CFG(0x0, 0x1B, 0x411111f0),
/* Pin Complex (NID 0x1D) */ - 0x01d71c05, - 0x01d71d9d, - 0x01d71e56, - 0x01d71f40, + AZALIA_PIN_CFG(0x0, 0x1D, 0x40548505),
/* Pin Complex (NID 0x1E) */ - 0x01e71cf0, - 0x01e71d11, - 0x01e71e11, - 0x01e71f41, - - /* Pin Complex (NID 0x21) */ - 0x02171c1f, - 0x02171d10, - 0x02171e21, - 0x02171f04, + AZALIA_PIN_CFG(0x0, 0x1E, 0x411111f0), };
const u32 pc_beep_verbs[] = {