V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36032 )
Change subject: soc/intel/{cnl, icl}: Update the DCACHE_BSP_STACK_SIZE to 129KiB
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36032/2/src/soc/intel/cannonlake/Kc...
File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/36032/2/src/soc/intel/cannonlake/Kc...
PS2, Line 128: sum of FSP stack requirement (128KiB) and CB stack requirement (1KiB).
from coreboot stack usage side we were thinking 1KB must be sufficient. […]
We checked the current coreboot stack usage which is ~400bytes and adding 1KiB to FSP stack requirement must be sufficient.
Even i couldn't get any reference to the stack alignment of 4KiB.
https://review.coreboot.org/c/coreboot/+/36032/2/src/soc/intel/icelake/Kconf...
File src/soc/intel/icelake/Kconfig:
https://review.coreboot.org/c/coreboot/+/36032/2/src/soc/intel/icelake/Kconf...
PS2, Line 77: In
good catch
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36032
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icedff8b42e86dc095fb68deb0b8f80b2667cfeda
Gerrit-Change-Number: 36032
Gerrit-PatchSet: 3
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 16 Oct 2019 04:00:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment