[coreboot-gerrit] Change in coreboot[master]: sb/intel/{bd82x6x,ibexpeak}: hide MEI if ME inoperable

[Evgeny Zinoviev (Code Review)]

Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39074 )

Change subject: sb/intel/{bd82x6x,ibexpeak}: hide MEI if ME inoperable
......................................................................

Patch Set 1:
> Patch Set 1:
>
> (1 comment)
> > Patch Set 1:
> >
> > IMO, this should be made optional. A Kconfig maybe? Not everybody
> > wants to hide errors.
>
> Well, not hiding the MEI device results in long waits because mei_me has to time out. I would appreciate if coreboot would log a message about it, at least.

BIOS should enable MEI 1 on error and recovery paths so it allows the user to update firmware and take it out of error/recovery condition. Should hide on disable path though.

If mei_me waits too long when ME is in error condition, probably mei_me should be fixed instead.