Patch Set 1:

(1 comment)

Patch Set 1:

IMO, this should be made optional. A Kconfig maybe? Not everybody
wants to hide errors.

Well, not hiding the MEI device results in long waits because mei_me has to time out. I would appreciate if coreboot would log a message about it, at least.

BIOS should enable MEI 1 on error and recovery paths so it allows the user to update firmware and take it out of error/recovery condition. Should hide on disable path though.

If mei_me waits too long when ME is in error condition, probably mei_me should be fixed instead.

View Change

To view, visit change 39074. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4a35bf5fc196e0a02b7591cdb8633d38f0c7f3e
Gerrit-Change-Number: 39074
Gerrit-PatchSet: 1
Gerrit-Owner: James <jye836@gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: James <jye836@gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Evgeny Zinoviev <me@ch1p.io>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 24 Feb 2020 13:47:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment