Marx Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38741 )
Change subject: soc/intel/cannonlake: Add tdc config for CML ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38741/3/src/soc/intel/cannonlake/in... File src/soc/intel/cannonlake/include/soc/vr_config.h:
https://review.coreboot.org/c/coreboot/+/38741/3/src/soc/intel/cannonlake/in... PS3, Line 57: TDC
that's a good suggestion.
Done
https://review.coreboot.org/c/coreboot/+/38741/3/src/soc/intel/cannonlake/vr... File src/soc/intel/cannonlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/38741/3/src/soc/intel/cannonlake/vr... PS3, Line 502: printk(BIOS_ERR, "ERROR: Unknown MCH (0x%x) in VR-config and apply Auto/default settings\n", mch_id);
Done
Done