Attention is currently required from: Krystian Hebel.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70106 )
Change subject: commonlib/helpers.h: use unsigned literals in definitions ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/70106/comment/951c9048_19f315a3 PS1, Line 21: so if result of : multiplication is negative If result of multiplying two positive integers is negative, further integer promotions don't matter much, because you've already got an undefined behaviour. I'd think of marking these constants as `LL` or `ULL`, otherwise the problem will repeat itself for `4295*MHz` some time later. The advantage of `LL` is that UBSan or something like it should report such an overflow, while wrapping of `ULL` is well defined.