Attention is currently required from: Name of user not set #1004065, Stefan Reinauer. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60737 )
Change subject: util/ifdtool: Add support for Denverton platforms. ......................................................................
Patch Set 1:
(3 comments)
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/60737/comment/5d96d219_8b262f05 PS1, Line 716: Maybe add
int has_10gbe_A = (platform == PLATFORM_DNV); int has_10gbe_B = ...
and use those below
https://review.coreboot.org/c/coreboot/+/60737/comment/2fc9f76a_f94a798f PS1, Line 732: if (platform == PLATFORM_DNV) { Use the booleans from above.
if (has_10gbe_A)
https://review.coreboot.org/c/coreboot/+/60737/comment/679f7482_bb799c09 PS1, Line 733: printf(" 10GB A Region Write Access: %s\n", 10GbE is the common terminology?