[coreboot-gerrit] Change in coreboot[master]: sc7180: Remove QcLib specific changes from CB UART

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42095 )

Change subject: sc7180: Remove QcLib specific changes from CB UART
......................................................................

Patch Set 11:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42095/1/src/soc/qualcomm/sc7180/qup... 
File src/soc/qualcomm/sc7180/qupv3_config.c:

https://review.coreboot.org/c/coreboot/+/42095/1/src/soc/qualcomm/sc7180/qup... 
PS1, Line 57: QUPV3_UART_SRC_HZ
> *ping*

*ping*

This is the unresolved comment.

https://review.coreboot.org/c/coreboot/+/42095/1/src/soc/qualcomm/sc7180/qup... 
PS1, Line 55: 	if (protocol != SE_PROTOCOL_UART) {
> Hi Julius, […]

Just to clarify, when I asked for the outstanding comments on this patch to be addressed, I was talking about the *unresolved* comment (the one on line 57 of the 'Base' side of this file diff). This comment here had already been marked resolved by me so I'm okay leaving that as is. The other comment is just about removing a constant definition that is no longer used which hopefully won't cause too much validation work.