[coreboot-gerrit] Change in ...coreboot[master]: security/tpm/tss/tcg-2.0: Add TPM2 function tlcl_getcapability()

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30826 )

Change subject: security/tpm/tss/tcg-2.0: Add TPM2 function tlcl_getcapability()
......................................................................

Patch Set 18:

(3 comments)

https://review.coreboot.org/#/c/30826/17/src/security/tpm/tss/tcg-2.0/tss.c 
File src/security/tpm/tss/tcg-2.0/tss.c:

https://review.coreboot.org/#/c/30826/17/src/security/tpm/tss/tcg-2.0/tss.c@... 
PS17, Line 379: 		       "supported yet\n", __func__);
> Shouldn't this assert() or error out?

Done

https://review.coreboot.org/#/c/30826/17/src/security/tpm/tss/tcg-2.0/tss_st... 
File src/security/tpm/tss/tcg-2.0/tss_structures.h:

https://review.coreboot.org/#/c/30826/17/src/security/tpm/tss/tcg-2.0/tss_st... 
PS17, Line 234: #define PCR_SELECT_MIN                ALIGN_UP(PLATFORM_PCR, 8)/8
> Just use DIV_ROUND_UP() for these

DIV_ROUND_UP() as function can't be used for PCR_SELECT_XXX. 
(braced-group can not be used with structure TPMS_PCR_SELECTION).
Will place the ALIGN_UP within ()

https://review.coreboot.org/#/c/30826/17/src/security/tpm/tss/tcg-2.0/tss_st... 
PS17, Line 235: #define PCR_SELECT_MAX                ALIGN_UP(IMPLEMENTATION_PCR, 8)/8
> Macros with complex values should be enclosed in parentheses

Done