build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31355 )
Change subject: libpayload: import libfdt from upstream ......................................................................
Patch Set 1:
(79 comments)
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/include/libfdt/f... File payloads/libpayload/include/libfdt/fdt.h:
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/include/libfdt/f... PS1, Line 22: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/include/libfdt/f... PS1, Line 23: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/include/libfdt/l... File payloads/libpayload/include/libfdt/libfdt.h:
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/include/libfdt/l... PS1, Line 21: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/include/libfdt/l... PS1, Line 22: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/include/libfdt/l... File payloads/libpayload/include/libfdt/libfdt_env.h:
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/include/libfdt/l... PS1, Line 22: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/include/libfdt/l... PS1, Line 23: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/include/libfdt/l... PS1, Line 75: #define CPU_TO_FDT32(x) ((EXTRACT_BYTE(x, 0) << 24) | (EXTRACT_BYTE(x, 1) << 16) | (EXTRACT_BYTE(x, 2) << 8) | EXTRACT_BYTE(x, 3)) line over 80 characters
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/include/libfdt/l... PS1, Line 76: #define CPU_TO_FDT64(x) ((EXTRACT_BYTE(x, 0) << 56) | (EXTRACT_BYTE(x, 1) << 48) | (EXTRACT_BYTE(x, 2) << 40) | (EXTRACT_BYTE(x, 3) << 32) | (EXTRACT_BYTE(x, 4) << 24) | (EXTRACT_BYTE(x, 5) << 16) | (EXTRACT_BYTE(x, 6) << 8) | EXTRACT_BYTE(x, 7)) line over 80 characters
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/include/libfdt/l... PS1, Line 113: #if !defined(MAC_OS_X_VERSION_10_7) || (MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_7) line over 80 characters
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/include/libfdt/l... File payloads/libpayload/include/libfdt/libfdt_internal.h:
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/include/libfdt/l... PS1, Line 21: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/include/libfdt/l... PS1, Line 22: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/include/libfdt/l... PS1, Line 59: #define FDT_RO_PROBE(fdt) \ Macros with flow control statements should be avoided
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/include/libfdt/l... PS1, Line 62: if ((err_ = fdt_ro_probe_(fdt)) != 0) \ do not use assignment in if condition
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/include/libfdt/l... PS1, Line 81: static inline const struct fdt_reserve_entry *fdt_mem_rsv_(const void *fdt, int n) line over 80 characters
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/include/libfdt/l... PS1, Line 84: (const struct fdt_reserve_entry *)((const char *)fdt + fdt_off_mem_rsvmap(fdt)); line over 80 characters
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt.c File payloads/libpayload/libfdt/fdt.c:
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt.c@19 PS1, Line 19: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt.c@20 PS1, Line 20: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt.c@156 PS1, Line 156: unsigned absoffset = offset + fdt_off_dt_struct(fdt); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt.c@203 PS1, Line 203: if (fdt_version(fdt) < 0x10 && fdt32_to_cpu(*lenp) >= 8 && ((offset - fdt32_to_cpu(*lenp)) % 8) != 0) line over 80 characters
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt.c@247 PS1, Line 247: if ((nextoffset = fdt_check_node_offset_(fdt, offset)) < 0) do not use assignment in if condition
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_addre... File payloads/libpayload/libfdt/fdt_addresses.c:
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_addre... PS1, Line 20: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_addre... PS1, Line 21: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_empty... File payloads/libpayload/libfdt/fdt_empty_tree.c:
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_empty... PS1, Line 19: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_empty... PS1, Line 20: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_overl... File payloads/libpayload/libfdt/fdt_overlay.c:
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_overl... PS1, Line 20: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_overl... PS1, Line 21: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_overl... PS1, Line 96: * device tree of a fragment, no matter how the actual targetting is 'targetting' may be misspelled - perhaps 'targeting'?
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_overl... PS1, Line 100: * the targetted node offset in the base device tree 'targetted' may be misspelled - perhaps 'targeted'?
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_overl... PS1, Line 215: fdt_for_each_subnode(child, fdto, node) that open brace { should be on the previous line
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_overl... PS1, Line 275: fdt_for_each_property_offset(fixup_prop, fdto, fixup_node) that open brace { should be on the previous line
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_overl... PS1, Line 322: sizeof(adj_val)); line over 80 characters
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_overl... PS1, Line 331: fdt_for_each_subnode(fixup_child, fdto, fixup_node) that open brace { should be on the previous line
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_overl... PS1, Line 574: fdt_for_each_property_offset(property, fdto, fixups_off) that open brace { should be on the previous line
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_overl... PS1, Line 611: fdt_for_each_property_offset(property, fdto, node) that open brace { should be on the previous line
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_overl... PS1, Line 630: fdt_for_each_subnode(subnode, fdto, node) that open brace { should be on the previous line
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_overl... PS1, Line 673: fdt_for_each_subnode(fragment, fdto, 0) that open brace { should be on the previous line
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_overl... PS1, Line 776: fdt_for_each_property_offset(prop, fdto, ov_sym) that open brace { should be on the previous line
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_overl... PS1, Line 783: if (path_len < 1 || memchr(path, '\0', path_len) != &path[path_len - 1]) line over 80 characters
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_overl... PS1, Line 789: /* format: /<fragment-name>/__overlay__/<relative-subnode-path> */ line over 80 characters
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_overl... PS1, Line 840: len + (len > 1) + rel_path_len + 1, &p); line over 80 characters
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_overl... PS1, Line 846: ret = overlay_get_target(fdt, fdto, fragment, &target_path); line over 80 characters
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_ro.c File payloads/libpayload/libfdt/fdt_ro.c:
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_ro.c@... PS1, Line 19: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_ro.c@... PS1, Line 20: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_ro.c@... PS1, Line 152: for (offset = fdt_next_node(fdt, -1, NULL);; Statements terminations use 1 semicolon
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_ro.c@... PS1, Line 257: return fdt_subnode_offset_namelen(fdt, parentoffset, name, strlen(name)); line over 80 characters
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_ro.c@... PS1, Line 316: if (((err = fdt_ro_probe_(fdt)) != 0) do not use assignment in if condition
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_ro.c@... PS1, Line 352: if ((offset = fdt_check_node_offset_(fdt, nodeoffset)) < 0) do not use assignment in if condition
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_ro.c@... PS1, Line 360: if ((offset = fdt_check_prop_offset_(fdt, offset)) < 0) do not use assignment in if condition
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_ro.c@... PS1, Line 373: if ((err = fdt_check_prop_offset_(fdt, offset)) < 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_ro.c@... PS1, Line 415: if (!(prop = fdt_get_property_by_offset_(fdt, offset, lenp))) { do not use assignment in if condition
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_ro.c@... PS1, Line 471: if (fdt_version(fdt) < 0x10 && (poffset + sizeof(*prop)) % 8 && fdt32_ld(&prop->len) >= 8) line over 80 characters
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_ro.c@... PS1, Line 498: if (fdt_version(fdt) < 0x10 && (offset + sizeof(*prop)) % 8 && fdt32_ld(&prop->len) >= 8) line over 80 characters
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_ro.c@... PS1, Line 580: if (p > 1) /* special case so that root path is "/", not "" */ line over 80 characters
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_ro.c@... PS1, Line 865: unsigned depth = 0; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_rw.c File payloads/libpayload/libfdt/fdt_rw.c:
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_rw.c@... PS1, Line 19: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_rw.c@... PS1, Line 20: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_rw.c@... PS1, Line 61: return (fdt_off_mem_rsvmap(fdt) < FDT_ALIGN(sizeof(struct fdt_header), 8)) line over 80 characters
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_rw.c@... PS1, Line 62: || (fdt_off_dt_struct(fdt) < (fdt_off_mem_rsvmap(fdt) + mem_rsv_size)) line over 80 characters
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_rw.c@... PS1, Line 63: || (fdt_off_dt_strings(fdt) < (fdt_off_dt_struct(fdt) + struct_size)) line over 80 characters
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_rw.c@... PS1, Line 64: || (fdt_totalsize(fdt) < (fdt_off_dt_strings(fdt) + fdt_size_dt_strings(fdt))); line over 80 characters
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_rw.c@... PS1, Line 82: #define FDT_RW_PROBE(fdt) \ Macros with flow control statements should be avoided
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_rw.c@... PS1, Line 85: if ((err_ = fdt_rw_probe_(fdt)) != 0) \ do not use assignment in if condition
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_rw.c@... PS1, Line 128: if ((err = fdt_splice_(fdt, p, oldlen, newlen))) do not use assignment in if condition
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_rw.c@... PS1, Line 142: if ((err = fdt_splice_(fdt, p, 0, newlen))) do not use assignment in if condition
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_rw.c@... PS1, Line 210: if ((err = fdt_splice_struct_(fdt, (*prop)->data, FDT_TAGALIGN(oldlen), do not use assignment in if condition
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_rw.c@... PS1, Line 226: if ((nextoffset = fdt_check_node_offset_(fdt, nodeoffset)) < 0) do not use assignment in if condition
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_strer... File payloads/libpayload/libfdt/fdt_strerror.c:
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_strer... PS1, Line 19: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_strer... PS1, Line 20: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_strer... PS1, Line 88: #define FDT_ERRTABSIZE (sizeof(fdt_errtable) / sizeof(fdt_errtable[0])) Prefer ARRAY_SIZE(fdt_errtable)
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_sw.c File payloads/libpayload/libfdt/fdt_sw.c:
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_sw.c@... PS1, Line 19: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_sw.c@... PS1, Line 20: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_sw.c@... PS1, Line 67: #define FDT_SW_PROBE(fdt) \ Macros with flow control statements should be avoided
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_sw.c@... PS1, Line 70: if ((err = fdt_sw_probe_(fdt)) != 0) \ do not use assignment in if condition
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_sw.c@... PS1, Line 91: #define FDT_SW_PROBE_MEMRSV(fdt) \ Macros with flow control statements should be avoided
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_sw.c@... PS1, Line 94: if ((err = fdt_sw_probe_memrsv_(fdt)) != 0) \ do not use assignment in if condition
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_sw.c@... PS1, Line 117: #define FDT_SW_PROBE_STRUCT(fdt) \ Macros with flow control statements should be avoided
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_sw.c@... PS1, Line 120: if ((err = fdt_sw_probe_struct_(fdt)) != 0) \ do not use assignment in if condition
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_wip.c File payloads/libpayload/libfdt/fdt_wip.c:
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_wip.c... PS1, Line 19: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/31355/1/payloads/libpayload/libfdt/fdt_wip.c... PS1, Line 20: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.