[coreboot-gerrit] Change in coreboot[master]: mb/google/deltaur: Add initial GPIO configuration

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39674 )

Change subject: mb/google/deltaur: Add initial GPIO configuration
......................................................................

Patch Set 11:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39674/11/src/mainboard/google/delta... 
File src/mainboard/google/deltaur/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39674/11/src/mainboard/google/delta... 
PS11, Line 135: PLTRST
> I'm starting to think the GPIO table is just wrong with all these resets... […]

If you means the table provide from HW, It's definitely wrong. So I always busy to fix the power leakage in S5...

https://review.coreboot.org/c/coreboot/+/39674/11/src/mainboard/google/delta... 
PS11, Line 201: NONE
> It's definitely active-low, it's pulled up to 3.3V. Let's try invert for now.

Here is the Drallion and Sarien device tree for this pin. If we invert this, be sure change device tree as well. I think it's fine.
ACPI_IRQ_LEVEL_LOW(GPP_C23_IRQ)