18 Nov
2020
18 Nov
'20
10:14 p.m.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47377 )
Change subject: mb/google/volteer: Enable RTD3 for SD card ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47377/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/47377/2/src/mainboard/google/voltee... PS2, Line 451: # Enable GPIO is disabled in mainboard.c for RTS5261
Can this not be handled in devicetree using multiple entries each with its own probe property? […]
Yes I had worked up a similar patch this weekend, need to update this.
--
To view, visit https://review.coreboot.org/c/coreboot/+/47377
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40fe05829783c7bce2a2c4c1520a4a7430642e26
Gerrit-Change-Number: 47377
Gerrit-PatchSet: 2
Gerrit-Owner: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 18 Nov 2020 21:14:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment