Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36136 )
Change subject: soc/intel: skl,cnl,icl: rely on TOLUM as cbmem_top returned by FSP
......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36136/3/src/soc/intel/icelake/memma...
File src/soc/intel/icelake/memmap.c:
https://review.coreboot.org/c/coreboot/+/36136/3/src/soc/intel/icelake/memma...
PS3, Line 54: fsp_find_bootloader_tolum
Fix cbmem_top on all FSP2.0 targets to use this, move it out of hob_verify. […]
quark,apollolake,denverton_ns are left; they all don't have ebda or some equivalent mechanism
https://review.coreboot.org/c/coreboot/+/36136/10/src/soc/intel/skylake/memm...
File src/soc/intel/skylake/memmap.c:
https://review.coreboot.org/c/coreboot/+/36136/10/src/soc/intel/skylake/memm...
PS10, Line 73: die("9.3: FSP_BOOTLOADER_TOLUM_HOB missing!\n");
Ack
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36136
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If66a00d1320917bc68afb32c19db0e24c6732812
Gerrit-Change-Number: 36136
Gerrit-PatchSet: 13
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 23 Oct 2019 22:27:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Michael Niewöhner
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment