Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38706 )
Change subject: security/vboot: relocate vb2ex_abort and vb2ex_printf
......................................................................
Patch Set 3:
Patch Set 3:
Would adding vb2ex_abort() and vb2ex_printf() to vboot library be the preferred solution?
By design, the "vb2ex" functions are supposed to be implemented by the caller. These are mostly lower-level functions interacting with drivers or hardware in some way. This also allows implementation to differ across the firmware being linked, i.e. coreboot or depthcharge.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38706
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica0103c5684b3d50ba7dc1b4c39559cb192efa81
Gerrit-Change-Number: 38706
Gerrit-PatchSet: 3
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-Comment-Date: Tue, 04 Feb 2020 16:28:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment