Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34298 )
Change subject: devicetree: Add accessors for chip_info
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34298/3/src/include/device/device.h
File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/34298/3/src/include/device/device.h...
PS3, Line 306: devtree_die();
Could this get __func__ passed as parameter? Otherwise, the die() message is rather imprecise.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34298
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70def4599509b8193e44ea3f02c4906f865b4469
Gerrit-Change-Number: 34298
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 15 Jul 2019 07:58:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment