Attention is currently required from: Xi Chen, Chien-Chih Tseng, Pi-Cheng Chen, Rex-BC Chen, Yu-Ping Wu. flora.fu@mediatek.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48622 )
Change subject: soc/mediatek/mt8192: add apusys init flow ......................................................................
Patch Set 13:
(7 comments)
File src/soc/mediatek/mt8192/apusys.c:
https://review.coreboot.org/c/coreboot/+/48622/comment/d7d5fe4f_79430f02 PS11, Line 19: 0x%p
%p […]
Done
https://review.coreboot.org/c/coreboot/+/48622/comment/cb8ca0bc_58059e3b PS11, Line 20: (void *)
Align with BIOS_INFO
Done
https://review.coreboot.org/c/coreboot/+/48622/comment/a22df845_4781934b PS11, Line 23: SIZE_MBOX_FUN
ARRAY_SIZE(mt8192_apu_mbox)
Done
https://review.coreboot.org/c/coreboot/+/48622/comment/24ac323a_9b563a76 PS11, Line 24: 0x%p
%p
Done
https://review.coreboot.org/c/coreboot/+/48622/comment/5479fbdc_90364625 PS11, Line 25: (void *)
Align with BIOS_INFO
Done
https://review.coreboot.org/c/coreboot/+/48622/comment/5f971d54_7b4a84c5 PS11, Line 37: SIZE_MBOX_FUN
ARRAY_SIZE(mt8192_apu_mbox)
Done
File src/soc/mediatek/mt8192/include/soc/apusys.h:
https://review.coreboot.org/c/coreboot/+/48622/comment/8b875ab5_d2dff3c8 PS11, Line 9: SIZE_MBOX_FUN
Using the ARRAY_SIZE macro, I don't think we need this.
Done