Attention is currently required from: Kapil Porwal, Sean Rhodes, Subrata Banik.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79882?usp=email )
Change subject: soc/intel/common/tcss: Guard disabling MUX with TCSS_HAS_USBC_OPS
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/common/block/tcss/Kconfig:
https://review.coreboot.org/c/coreboot/+/79882/comment/6e2ae1c5_22b0321e :
PS6, Line 10: default n
I don't think you want `default n` here since it will prevent other Kconfigs from selecting it later. Leaving it undefined results in it being set to N if not explicitly selected elsewhere
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79882?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia848668ae9af4637fc7cffec9eb694f29d7deba9
Gerrit-Change-Number: 79882
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Thu, 11 Jan 2024 15:45:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment