Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46605 )
Change subject: [RFC] Replace strapping_id entries with new board configuration entry ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46605/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46605/1//COMMIT_MSG@10 PS1, Line 10: possibly deprecating the three separate "strapping ID" tables with : which it is slightly redundant with.
Let's do that deprecation right away in the same patch?
Ack
https://review.coreboot.org/c/coreboot/+/46605/1/src/commonlib/include/commo... File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/46605/1/src/commonlib/include/commo... PS1, Line 83: 0x0039
Could you use 0x0040 instead, please? CB:40520 uses 0x0039 and already had to be bumped once.
Oops sorry about that, will bump up.
https://review.coreboot.org/c/coreboot/+/46605/1/src/include/fw_config.h File src/include/fw_config.h:
https://review.coreboot.org/c/coreboot/+/46605/1/src/include/fw_config.h@11 PS1, Line 11: #define DEFAULT_FW_CONFIG (uint64_t)0
Can we please use the existing UNDEFINED_STRAPPING_ID (~0, or now better ~(uint64_t)0) for this? For […]
Done
https://review.coreboot.org/c/coreboot/+/46605/1/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/46605/1/src/lib/coreboot_table.c@20 PS1, Line 20: #include <version.h>
Sort it in a separate patch, which can be submitted without discussion and makes the diff smaller.
Ack