4 comments:
possibly deprecating the three separate "strapping ID" tables with
which it is slightly redundant with.
Let's do that deprecation right away in the same patch?
Ack
File src/commonlib/include/commonlib/coreboot_tables.h:
Patch Set #1, Line 83: 0x0039
Could you use 0x0040 instead, please? CB:40520 uses 0x0039 and already had to be bumped once.
Oops sorry about that, will bump up.
Patch Set #1, Line 11: #define DEFAULT_FW_CONFIG (uint64_t)0
Can we please use the existing UNDEFINED_STRAPPING_ID (~0, or now better ~(uint64_t)0) for this? For […]
Done
File src/lib/coreboot_table.c:
Patch Set #1, Line 20: #include <version.h>
Sort it in a separate patch, which can be submitted without discussion and makes the diff smaller.
Ack
To view, visit change 46605. To unsubscribe, or for help writing mail filters, visit settings.