Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38474 )
Change subject: soc/mediatek/mt8183: Fix typo error of DRAMC setting
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38474/3/src/soc/mediatek/mt8183/emi...
File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/38474/3/src/soc/mediatek/mt8183/emi...
PS3, Line 461: clrsetbits32(dst_addr, 0x7f << 16, value << 16);
0x16 converts to 22, not 16. Is this intentional?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38474
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5edac32938def50836f386426e7deb652b80d42d
Gerrit-Change-Number: 38474
Gerrit-PatchSet: 3
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 20 Jan 2020 13:34:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment