Attention is currently required from: Arthur Heymans, Nico Huber.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64186?usp=email )
Change subject: haswell NRI: Configure initial MC settings
......................................................................
Patch Set 4:
(2 comments)
This change is ready for review.
File src/northbridge/intel/haswell/native_raminit/configure_mc.c:
https://review.coreboot.org/c/coreboot/+/64186/comment/de621ea3_5f5a5bd7 :
PS3, Line 90: /* 1067 MHz, 1333 MHz, 1600 MHz, 1867 MHz, 2133 MHz, */
Are these values in MHz or MT/s?
Done
https://review.coreboot.org/c/coreboot/+/64186/comment/80724e35_ff30df12 :
PS3, Line 236:
is this a tab?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64186?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If33846b51cb1bab5d0458fe626e13afb1bdc900e
Gerrit-Change-Number: 64186
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 11 Apr 2024 16:57:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment