Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31120 )
Change subject: mainboard/{google,intel}: Remove SaGv hard coding
......................................................................
Patch Set 3:
Patch Set 2:
in my mind, all Sagv value should be just enable because in MRC code SaGv enable handles both high and low freq training. so we shouldn't be bothered.
I don't know what makes to select Fixed High or low specifically, unless its been early silicon.
I think at this point we can change Its value to SaGv Enable. but doing it into this patch will not justify this patch objective.
so pushed CB:31132 patch to enable SaGv in CNL-Y and CNL-U
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31120
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If007589d5c1368602928b1550ec8788e65f70c05
Gerrit-Change-Number: 31120
Gerrit-PatchSet: 3
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 29 Jan 2019 05:46:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment