Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38940 )
Change subject: cpu/x86/name: Make name.c file available in romstage ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38940/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38940/1//COMMIT_MSG@7 PS1, Line 7: Making
Please use imperative mood: Make
Done
https://review.coreboot.org/c/coreboot/+/38940/1//COMMIT_MSG@14 PS1, Line 14: intension
intention
Done
https://review.coreboot.org/c/coreboot/+/38940/1//COMMIT_MSG@9 PS1, Line 9: In this patch name.c file that includes the definition for : fill_processor_name which is used by the report_cpu_info : function is been made available in romstage. : : This is done to facilitate the report_platform_info to be called : from romstage, as the intension is to move the report_platform_info : to romstage for all S0C's due to the bootblock size constraint.
Please re-flow for 75 characters text width.
Done
https://review.coreboot.org/c/coreboot/+/38940/1//COMMIT_MSG@15 PS1, Line 15: S0C
SOC’s
Done