build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34980 )
Change subject: southbridge/intel: Tidy up preprocessor and headers
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34980/6/src/southbridge/intel/i8280...
File src/southbridge/intel/i82801ix/i82801ix.h:
https://review.coreboot.org/c/coreboot/+/34980/6/src/southbridge/intel/i8280...
PS6, Line 217: int smbus_read_byte(unsigned device, unsigned address);
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/34980/6/src/southbridge/intel/i8280...
PS6, Line 217: int smbus_read_byte(unsigned device, unsigned address);
Prefer 'unsigned int' to bare use of 'unsigned'
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34980
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52a7b39566acd64ac21a345046675e05649a40f5
Gerrit-Change-Number: 34980
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 21 Aug 2019 05:40:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment