Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35214/1/src/mainboard/google/kahlee...
File src/mainboard/google/kahlee/variants/baseboard/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35214/1/src/mainboard/google/kahlee...
PS1, Line 28: sku_id
I wonder if we should update ec_boardid.c (https://review.coreboot.org/cgit/coreboot.git/tree/src/ec/google/chromeec/ec...) to add support for a sku_id() implementation for chromeec. Then, it wouldn't have to be duplicated across multiple mainboards.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35214
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I631f62021e8104a69a43667a811c9c23e3105596
Gerrit-Change-Number: 35214
Gerrit-PatchSet: 1
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Magf -
magf@bitland.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 02 Sep 2019 20:56:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment