Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38012 )
Change subject: nb/intel/sandybridge: add and use ME stolen memory and lock bit defines
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38012/1/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/sandybridge.h:
https://review.coreboot.org/c/coreboot/+/38012/1/src/northbridge/intel/sandy...
PS1, Line 86: MELCK
I got this name from the official documentation 326765-005
Ah, MELCK refers to the field. The name I have uses the register name as prefix and `MASK` as suffix.
https://review.coreboot.org/c/coreboot/+/38012/1/src/northbridge/intel/sandy...
PS1, Line 87: ME_STLEN_EN
same
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38012
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4663498b10a5eedcc1aa51088b984ecc49ef23e
Gerrit-Change-Number: 38012
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 31 Dec 2019 17:44:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment