Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40245 )
Change subject: mainboard/volteer: Update Aux settings for Port 0 ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40245/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40245/1/src/mainboard/google/voltee... PS1, Line 130: 1
Thanks for confirming this Brandon. I think we need one additional change. […]
Ack
https://review.coreboot.org/c/coreboot/+/40245/1/src/mainboard/google/voltee... PS1, Line 131: 0x090E000A
putting the pad encoding here is pretty obscure. […]
removed this and will instead rely on baseboard gpio
https://review.coreboot.org/c/coreboot/+/40245/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/40245/1/src/mainboard/google/voltee... PS1, Line 219: NF6
coreboot GPIO initialization happens before FSP-S runs.
Ack