Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45336 )
Change subject: soc/intel/common/block: Add Intel common reset code ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45336/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45336/5//COMMIT_MSG@7 PS5, Line 7: soc/intel/common/block
BTW, I just noticed that there is already a reset.c in soc/intel/common: https://review.coreboot. […]
yes, i had thought on this as well but due to below reason I have decided to kept inside common block code (although reset is not any IP block but still a common place where we can refer both core and atom family code like power_limit, acpi etc)
1. Unresolved common code macros and function from "src/soc/intel/common/reset.c" like below because "src/soc/intel/common/reset.c" is included by older SoCs like BSW, Quark are not part of IA common code scope.
#include <intelblocks/cse.h> #include <intelblocks/pmclib.h>
cse_request_global_reset pmc_global_reset_enable