View Change
1 comment:
Commit Message:
Patch Set #5, Line 7: soc/intel/common/block
BTW, I just noticed that there is already a reset.c in soc/intel/common: https://review.coreboot. […]
yes, i had thought on this as well but due to below reason I have decided to kept inside common block code (although reset is not any IP block but still a common place where we can refer both core and atom family code like power_limit, acpi etc)
1. Unresolved common code macros and function from "src/soc/intel/common/reset.c" like below because "src/soc/intel/common/reset.c" is included by older SoCs like BSW, Quark are not part of IA common code scope.
#include <intelblocks/cse.h>
#include <intelblocks/pmclib.h>
cse_request_global_reset
pmc_global_reset_enable
To view, visit change 45336. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icafe931ba9920501cf5448290ddd9f897760bb75
Gerrit-Change-Number: 45336
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 17 Sep 2020 06:40:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Gerrit-MessageType: comment