Attention is currently required from: Selma Bensaid, Tim Wawrzynczak, Paul Menzel, Andy Yeh, kiran2.kumar@intel.com, ShawnX Tu.
Bernardo Perez Priego has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58374 )
Change subject: mb/google/brya: Update camera NVM parameters
......................................................................
Patch Set 9:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58374/comment/45d21804_7959f3b8
PS8, Line 8:
: Change HID name from INT3499 to PRP0001 along with size and
: address width. Size decreased from 10K to 2K, address width
: decreased from 14 to 8.
:
: BUG=b:203014972
: Test= Boot board and issue commands:
: `cat /sys/bus/i2c/devices/i2c-PRP0001:02/eeprom > ./brya_imx208_eeprom.bin`
: `hexdump -C brya_imx208_eeprom.bin > brya_imx208_eeprom_dump.log`
: You should see the result in brya_imx208_eeprom_dump.log to be same as module
: nvm file by vendor provided or meet the Intel nvm calibration format.
: (e.g. first 4 bytes be 0x01, 0x03, 0x01, 0x00)
:
nit: re-flow for 72 characters wide
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58374
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2366ba4c8bb70d8cc82e64ca585b118a96260c0
Gerrit-Change-Number: 58374
Gerrit-PatchSet: 9
Gerrit-Owner: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Andy Yeh
andy.yeh@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: ShawnX Tu
shawnx.tu@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: kiran2.kumar@intel.com
Gerrit-CC: Bernardo Salvador Perez Priego
bernardospp@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Andy Yeh
andy.yeh@intel.com
Gerrit-Attention: kiran2.kumar@intel.com
Gerrit-Attention: ShawnX Tu
shawnx.tu@intel.com
Gerrit-Comment-Date: Thu, 02 Dec 2021 21:51:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment