Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46651 )
Change subject: sc7180: enable RECOVERY_MRC_CACHE ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46651/1/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/46651/1/src/mainboard/google/trogdo... PS1, Line 17: I think you should be able to set PRESERVE here for UNIFIED_MRC_CACHE and not worry about setting them individually for each of the caches below?
https://review.coreboot.org/c/coreboot/+/46651/1/src/soc/qualcomm/sc7180/Kco... File src/soc/qualcomm/sc7180/Kconfig:
https://review.coreboot.org/c/coreboot/+/46651/1/src/soc/qualcomm/sc7180/Kco... PS1, Line 21: HAS_RECOVERY_MRC_CACHE On Intel platforms, we have done this at the mainboard level so that it stays in sync with fmap changes to add the required MRC cache region and let's the board decide if it needs it depending upon whether it is using VBOOT.
Additionally, I think you would want to set the `MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN` config too.