Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42970 )
Change subject: soc/amd/picasso: Add support for generating I2S machine device ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42970/1/src/soc/amd/picasso/acp.c File src/soc/amd/picasso/acp.c:
https://review.coreboot.org/c/coreboot/+/42970/1/src/soc/amd/picasso/acp.c@8... PS1, Line 83: "dmic-gpios" This differs from the static asl. For posterity, acpi_find_gpio() eventually utilizes gpio_suffixes array of strings which is { "gpios", "gpio" }. So when acp3x-rt5682-max9836.c driver calls devm_gpiod_get(&pdev->dev, "dmic", GPIOD_OUT_LOW); that string is composed.