Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78954?usp=email )
Change subject: mb/google/geralt: Create variant Ciri
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78954/comment/6f4a1246_cd073939 :
PS2, Line 9: and enable MAX98390 AMP for it.
Last comment:
I mean, this commit isn't even creating anything - it's just
adding the name to the existing Kconfig files.
I agree, but you only know, once you looked at the diff. This is what I tried to improve.
Anyway, thank you for taking the time to comment. I also agree, it is not such a big issue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78954?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7bbe9ed5e722a70bab1c799a61ce38d2ad58ab25
Gerrit-Change-Number: 78954
Gerrit-PatchSet: 5
Gerrit-Owner: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 16 Nov 2023 13:40:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment