Attention is currently required from: Marc Jones, Jonathan Zhang, Johnny Lin, Rocky Phagura, Angel Pons, Arthur Heymans, Kyösti Mälkki.
Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52918 )
Change subject: src/console: add interrupt enable and status methods
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Were the changes submitted, where SMM has console without DEBUG_SMI?
No, shall I include it here or submit as a separate patch? It's a one file change in smm_module_handler.c
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52918
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e6fe8b82dd6b4d10f84ef4ac28c7cddc71c1bc9
Gerrit-Change-Number: 52918
Gerrit-PatchSet: 2
Gerrit-Owner: Rocky Phagura
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Rocky Phagura
rphagura@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Rocky Phagura
rphagura@fb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 06 May 2021 15:54:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment