2 Feb
2021
2 Feb
'21
5:03 p.m.
Attention is currently required from: Martin Roth, Angel Pons, EricR Lai. Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49954 )
Change subject: mb/google/guybrush: stubs to configure GPIOs ......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/49954/comment/c2ee4557_088828c3 PS9, Line 3: #ifndef __BASEBOARD_COMMON_VARIANTS_H__
Why add common here?
Nice catch, from earlier edit.
--
To view, visit https://review.coreboot.org/c/coreboot/+/49954
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5afd2df396ba41f7d25fa7ff6879b7c1f82f438c
Gerrit-Change-Number: 49954
Gerrit-PatchSet: 10
Gerrit-Owner: Mathew King mathewk@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 02 Feb 2021 17:03:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment