Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45153 )
Change subject: mb/google/zork:Add dptc interface support for morphius ......................................................................
Patch Set 10:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45153/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45153/1//COMMIT_MSG@7 PS1, Line 7: mb/google/zork:Add dptc interface support
Please add a space after the colon.
Chris - this still needs to be addressed.
https://review.coreboot.org/c/coreboot/+/45153/1//COMMIT_MSG@9 PS1, Line 9: Add dptc interface in devicetree.the variants can set below power
Please add a space after the dot/period.
Done
https://review.coreboot.org/c/coreboot/+/45153/1//COMMIT_MSG@12 PS1, Line 12: dptc_enable = 1 : dptc_fast_ppt_limit = 24000 : dptc_slow_ppt_limit = 20000 : dptc_sustained_power_limit = 6000
Please indent with four spaces.
Done
https://review.coreboot.org/c/coreboot/+/45153/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45153/6//COMMIT_MSG@12 PS6, Line 12: dptc_enable = 1 : dptc_fast_ppt_limit = 24000 : dptc_slow_ppt_limit = 20000 : dptc_sustained_power_limit = 6000
What variant actually needs this? Instead of adding dptc_enable to 0, can you instead set dptc_enabl […]
Done