Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46867 )
Change subject: amdfwtool: Add an option to show debug message ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/46867/2/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/46867/2/util/amdfwtool/amdfwtool.c@... PS2, Line 604: it would be good to print something like "PSP firmware components:" before printing the filenames to provide some context. same for the dump_bdt_firmwares function below
https://review.coreboot.org/c/coreboot/+/46867/2/util/amdfwtool/amdfwtool.c@... PS2, Line 1481: == 1 I'd drop the == 1 in there